OceanMesh2D icon indicating copy to clipboard operation
OceanMesh2D copied to clipboard

infinite loops in `clean`

Open krober10nd opened this issue 5 years ago • 3 comments

  • If inverted elements appear (negative qualities), then msh.clean will not be able to exit and repeat the connectivity improvement code infinitely.

krober10nd avatar Nov 20 '20 19:11 krober10nd

does this still happen? the idea was that it would do additional cleaning that would correct the inverted elements and eventually become positive.

WPringle avatar Feb 26 '21 16:02 WPringle

rarely but yes, it can still happen. I haven't done much meshing in recent months using OM. But sometimes you have to tinker with the cleaning operations to avoid this to happen.

Almost always I turn the implicit smoother off. Lately, I just use the patch smoother in areas that I want better qualities.

krober10nd avatar Feb 26 '21 18:02 krober10nd

Yeah maybe the implicit smoother should be discouraged

WPringle avatar Feb 26 '21 18:02 WPringle