cgru
cgru copied to clipboard
Refactor "Cmd" into more job, render, user sections
I was thinking about perhaps splitting up the Cmd class for manipulation into more specific classes.
Eg. job = af.Cmd.getJob(jobId) job.setNeededProperties("gpu")
render = af.Cmd.getRender() render.setNimby()
It makes manipulating jobs and renders easier and more logical.
I would be more than willing to start this process.
Might be best to have it in a complete seperate module 'afcmd'?
Hi. Sorry for a delay, i was on vocation.
I am agree with you. And yes, may be better to separate afcmd, keeping af for a jobs submission only.
ps It seems that your Afanasy manipulation via Python API is deeper that any other (and me too).
I've made a branch in my own repo for developing
https://github.com/lithorus/cgru/tree/afcmd
It has the basic the features from the Cmd class already.
It should now be feature complete with the Cmd class in af
Should I make a pull request?
Lets wait for a 2.3.0 release. It is already lots of changes in this release. And there is no plans to change code until release, only if some bugs.
You're right if 2.3.0 is close to release it might be better for a 3.0 release?
Then we can perhaps remove the "old" Cmd class in af to make things cleaner.
I will continue working on more functions in the afcmd module. And perhaps improve a few things in af.