Mesh_3: fix use of initial_points_generator (fix #9159)

Open lrineau opened this issue 1 month ago • 10 comments

Summary of Changes

The bug was in #7798. The generator was called with its parameter n = 0 instead of its default value.

Todo

[x] Add test

Release Management

Affected package(s): Mesh_3
Issue(s) solved (if any): fix #9159

Dec 10 '25 11:12 lrineau

Is the problem the same for initialisation for a grey level image?

Dec 10 '25 13:12 afabri

Is the problem the same for initialisation for a grey level image?

Yes, and this PR fixes it as well.

Dec 10 '25 13:12 lrineau

/build:doc_v1

Dec 10 '25 14:12 lrineau

It is not related to the bug that was reported, but can you clarify in the documentation of this operator() what n=20 means.. Does it generate 20 points per connected component, or for the entire image?

Dec 10 '25 14:12 afabri

/build:doc_v1

Dec 10 '25 15:12 lrineau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9178/doc_v1/Manual/index.html

Dec 10 '25 15:12 github-actions[bot]

/build:doc_v2

Dec 10 '25 15:12 lrineau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9178/doc_v2/Manual/index.html

Dec 10 '25 16:12 github-actions[bot]

Mesh_3 fully red in CGAL-6.2-Ic-60

Dec 11 '25 08:12 sloriot

Mesh_3 fully red in CGAL-6.2-Ic-60

Sorry, I forgot to check other .cpp with ctest. That passes, now, after commit fffffcde4a57775cf4c976da758234c6206ae4dc.

Dec 11 '25 09:12 lrineau