cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Added Do_intersect functor to traits classes and cleaned up

Open efifogel opened this issue 1 month ago • 2 comments

Summary of Changes

This is the first phase of fixing #9151. I submit it separately, as it involves several source files, and I'd like to start testing on various platforms.

I've added the functor Do_intersect to all traits classes. In particular, I added a robust implementation to the following traits:

  1. Arr_segment_traits_2
  2. Arr_non_caching_segment_traits_2
  3. Arr_linear_traits_2
  4. Arr_geodesic_arc_on_sphere_traits_2
  5. Arr_line_arc_traits_2.h
  6. Arr_circular_arc_traits_2.h
  7. Arr_circular_line_arc_traits_2.h I used Intersect to implement Do_intersect in the traits below. These implementations are not robust when using inexact constructions
  8. Arr_circle_segment_traits_2
  9. Arr_conic_traits_2
  10. Arr_Bezier_traits_2
  11. Arr_rational_function_traits_2
  12. Arr_algebraic_segment_traits_2

Release Management

  • Affected package(s): Arrangement_on_surface_2
  • Issue(s) solved (if any): partial fix of #9151
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

efifogel avatar Dec 09 '25 15:12 efifogel

------------------------------------------------------------------
- Arrangement_on_surface_2/ProgramOutput.test_traits_segments__data_segments_do_intersect__segment_traits
------------------------------------------------------------------

Error: cannot open file data/segments/do_intersect

and new warnings in CGAL-6.2-Ic-60

sloriot avatar Dec 11 '25 08:12 sloriot

ops. I fixed it.


/_____/) o /_________ __ // (____ ( ( ( (/ (/-(-'_(/ _/

On Thu, 11 Dec 2025 at 10:26, Sebastien Loriot @.***> wrote:

sloriot left a comment (CGAL/cgal#9177) https://github.com/CGAL/cgal/pull/9177#issuecomment-3640788861


  • Arrangement_on_surface_2/ProgramOutput.test_traits_segments__data_segments_do_intersect__segment_traits

Error: cannot open file data/segments/do_intersect

and new warnings in CGAL-6.2-Ic-60

— Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/pull/9177#issuecomment-3640788861, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBNOBABM7RNX2SDVX6LWT4BETB7AVCNFSM6AAAAACOQF44BKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNBQG44DQOBWGE . You are receiving this because you authored the thread.Message ID: @.***>

efifogel avatar Dec 11 '25 08:12 efifogel