cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Intersections: Consistent behavior of Circle_2 and Sphere_3

Open soesau opened this issue 3 months ago • 4 comments

Summary of Changes

Circle_2 and Sphere_3 intersections are not fully consistent. The Circle_2 - Segment_2 intersection does consider inclusion as intersection. The same is true for Sphere_3 and Iso_cuboid_3.

This PR changes the behavior of those two intersection methods and adds specific intersection methods with inclusion for Circle_2 and Iso_rectangle_2 to AABB_traits_2 with static filter. The same will be done for Sphere_3, Iso_cuboid_3 and AABB_traits_3.

Release Management

  • Affected package(s): AABB_tree, Intersection_2 Intersection_3
  • Issue(s) solved (if any): fix #8907, fix #8891, fix #6404

soesau avatar Oct 07 '25 17:10 soesau

documentation still needs to be updated, but can be tested already

soesau avatar Oct 17 '25 16:10 soesau

Looks in CGAL-6.2-Ic-30 but the PR is still under review.

sloriot avatar Oct 30 '25 19:10 sloriot

Edit: The timeouts are due to another PR.

I suspect this PR to be responsible for the timeouts . However, the timeouts only concern debug compilations and could not be reproduced locally (msvc).

soesau avatar Oct 31 '25 17:10 soesau

Ping @soesau

sloriot avatar Dec 04 '25 17:12 sloriot