cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Convex_hull_3: Add named parameter geom_traits

Open afabri opened this issue 9 months ago • 4 comments

Summary of Changes

Instead of the traits class being a \tparam we make it a named parameter. This is a breaking change, but we have to fix an ambiguity detected by one compiler, as reported in Issue #8759

Todo

  • [ ] documentation
  • [x] changes
  • [ ] do the same for other functions in the package

Release Management

  • Affected package(s): Convex_hull_3
  • Issue(s) solved (if any): fix #8759
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

afabri avatar Mar 27 '25 11:03 afabri

/build:v0

afabri avatar Mar 27 '25 14:03 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8807/v0/Manual/index.html

github-actions[bot] avatar Mar 27 '25 14:03 github-actions[bot]

It seems that the obvious non-breaking solution would have been to constrain the overload that takes Traits, for instance by checking that it has a method collinear_3_object. Does that not work, or does the named parameter bring some other benefit?

mglisse avatar Apr 01 '25 08:04 mglisse

@sloriot had proposed to also add a point property map

afabri avatar Apr 01 '25 09:04 afabri