cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Shape_detection: Add a way to pass input normal to faces

Open sloriot opened this issue 1 year ago • 14 comments

Summary of Changes

Avoid computing them when they are known.

  • Normals are only used for estimating the angle between neighbor faces. PCA is used to estimate the plane.
  • sorting should be reusing the triangulation of faces that is already done in regions (pass the internal map to sort() for exemple). PCA is also used here to estimate the flatness score of a face in its neighborhood
  • About sorting: I'm not sure it wouldn't be a better idea to simply sort using the area of the faces and ignore flatness of the neighborhood.

Release Management

sloriot avatar Dec 02 '24 16:12 sloriot

Successfully tested in CGAL-6.1-Ic-59

sloriot avatar Jan 09 '25 17:01 sloriot

/build:v0

soesau avatar Mar 27 '25 11:03 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html

github-actions[bot] avatar Mar 27 '25 11:03 github-actions[bot]

/build:v0

soesau avatar Apr 09 '25 13:04 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html

github-actions[bot] avatar Apr 09 '25 13:04 github-actions[bot]

Successfully tested in CGAL-6.1-Ic-132

sloriot avatar Apr 16 '25 16:04 sloriot

If we really want to get an option without PCA, we should also do a similar change for polylines (using squared length and one representative halfedge). What do you think @soesau ?

sloriot avatar May 22 '25 08:05 sloriot

Yes, we can offer that as an alternative.

soesau avatar May 22 '25 08:05 soesau

Yes, we can offer that as an alternative.

Do you mind adding that to your TODO list? AFAIU Mael would need it.

sloriot avatar May 22 '25 08:05 sloriot

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar May 22 '25 09:05 github-actions[bot]

/build:v0

soesau avatar Aug 04 '25 14:08 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html

github-actions[bot] avatar Aug 04 '25 14:08 github-actions[bot]

/build:v0

soesau avatar Oct 17 '25 16:10 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html

github-actions[bot] avatar Oct 17 '25 16:10 github-actions[bot]