Shape_detection: Add a way to pass input normal to faces
Summary of Changes
Avoid computing them when they are known.
- Normals are only used for estimating the angle between neighbor faces. PCA is used to estimate the plane.
- sorting should be reusing the triangulation of faces that is already done in regions (pass the internal map to
sort()for exemple). PCA is also used here to estimate the flatness score of a face in its neighborhood - About sorting: I'm not sure it wouldn't be a better idea to simply sort using the area of the faces and ignore flatness of the neighborhood.
Release Management
- Affected package(s):
Shape_detection - small feature: Pass_face_normals_for_region_growing
- Issue(s) solved (if any):
Successfully tested in CGAL-6.1-Ic-59
/build:v0
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html
/build:v0
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html
Successfully tested in CGAL-6.1-Ic-132
If we really want to get an option without PCA, we should also do a similar change for polylines (using squared length and one representative halfedge). What do you think @soesau ?
Yes, we can offer that as an alternative.
Yes, we can offer that as an alternative.
Do you mind adding that to your TODO list? AFAIU Mael would need it.
This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.
/build:v0
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html
/build:v0
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html