cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Spelling mistakes found checking en-GB to en-US

Open albert-github opened this issue 1 year ago • 6 comments

Based an #8514 a check words that are misspelling in en-US but are correct in en-GB (CGAL normally uses en-US)

Recognized by my spelling checker and by google translate as misspelled

  • analyse ==> analyze
  • analysed ==> analyzed
  • analysing ==> analyzing
  • behaviour ==> behavior
  • behaviours ==> behaviors
  • centre ==> center
  • centred ==> centered
  • centres ==> centers
  • characterising ==> characterizing
  • colour ==> color
  • colouring ==> coloring
  • colours ==> colors
  • customisation ==> customization
  • equalise ==> equalize
  • favour ==> favor
  • favourable ==> favorable
  • favoured ==> favored
  • flavours ==> flavors
  • fulfils ==> fulfills
  • Generalised ==> Generalized
  • initialisation ==> initialization
  • initialise ==> initialize
  • initialised ==> initialized
  • initialises ==> initializes
  • initialising ==> initializing
  • licence ==> license
  • localisation ==> localization
  • localise ==> localize
  • maximise ==> maximize
  • maximises ==> maximizes
  • millimetres ==> millimeters
  • modelled ==> modeled
  • mould ==> mold
  • Neighbour ==> Neighbor
  • neighbouring ==> neighboring
  • neighbours ==> neighbors
  • normalisation ==> normalization
  • Normalise ==> Normalize
  • optimisation ==> optimization
  • optimisations ==> optimizations
  • optimise ==> optimize
  • optimiser ==> optimizer
  • optimising ==> optimizing
  • parameterised ==> parameterized
  • practise ==> practice
  • prioritised ==> prioritized
  • realise ==> realize
  • recognised ==> recognized
  • Recognising ==> Recognizing
  • Regularised ==> Regularized
  • specialisation ==> specialization
  • specialisations ==> specializations
  • specialised ==> specialized
  • standardise ==> standardize
  • utilisation ==> utilization
  • Visualisation ==> Visualization
  • visualised ==> visualized

Recognized by my spelling checker but not by google translate as misspelled

  • Acknowledgement ==> Acknowledgment
  • analogue ==> analog
  • cancelled ==> canceled
  • Cancelling ==> Canceling
  • grey ==> gray
  • greyed ==> grayed
  • modeller ==> modeler Remark a bit strange as modelled ==> modeled is recognized
  • Modellers ==> Modelers
  • modelling ==> modeling

Questions:

  • Should all those misspellings be corrected (except when in the bib file and the original document also has the "misspelling").
  • should we have 1 PR per package

or

  • 1 PR per unique misspelled word(-type)

0r

  • ...

albert-github avatar Oct 03 '24 16:10 albert-github

Note that we do not want to change if the word is part of a function name, because that would be hassle for users. I was for example wondering about gray, but we do it good here.

afabri avatar Oct 03 '24 16:10 afabri

No variable, class, namespace, function names etc. I would leave out (and bib files have to be checked against the original title as defined by the author(s))

albert-github avatar Oct 03 '24 16:10 albert-github

So if it is only documentation and comment, then I would say, make it just a single PR for the first category.
Concering mould it seems correct to me. See for example here. I guess the word is just too specific.

afabri avatar Oct 03 '24 16:10 afabri

In fact no. Mould is British.

afabri avatar Oct 03 '24 16:10 afabri

I'll have a look.

I think the cancelled / modeller should also be done as e.g. the word canceled is used (e.g. Linear_cell_complex/demo/Linear_cell_complex/MainWindow.cpp) so this would be more consistent (similar for modeller e.g. Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt) the other words I didn't check yet.

albert-github avatar Oct 03 '24 17:10 albert-github

  • I've pushed a proposed patch, pull request #8519 for the general part
  • I've just pushed a proposed patch, pull request #8522 for the "bib" part

albert-github avatar Oct 06 '24 09:10 albert-github