cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Lab - add polylines to selection of edges

Open janetournois opened this issue 1 year ago • 8 comments

Summary of Changes

With this PR

  • load a surface triangle mesh
  • load a set of polylines (*.polylines.txt, or *.cgal, or *.txt)
  • create a selection item containing the polylines as selected edges (in PMP -> Select edges)

Release Management

  • Affected package(s): CGAL lab
  • License and copyright ownership: unchanged

janetournois avatar Aug 13 '24 15:08 janetournois

Warnings in I-c-348, but I think it is to early for the testsuite as there are todos in the code and lots of debug std::cout, which is normal as this is only a draft PR @sloriot

afabri avatar Oct 15 '24 06:10 afabri

I guess the warning in I-c-351 comes from this PR.

@janetournois can you check if the plugin does what you want to achieve. I can then throw out debug code and output.

afabri avatar Oct 18 '24 06:10 afabri

Successfully tested in CGAL-6.1-Ic-14

sloriot avatar Nov 08 '24 14:11 sloriot

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar Apr 07 '25 10:04 github-actions[bot]

@janetournois I compiled it and it works. And I am wondering if it would make sense that as soon as the selection item is generated, the polylines item should be removed.

afabri avatar May 13 '25 15:05 afabri

What do I have to do that the clipper also clips the selection?

afabri avatar May 13 '25 15:05 afabri

What do I have to do that the clipper also clips the selection?

select both item and selection_item together, and run the clipping plugin on the 2 selected items together

janetournois avatar May 13 '25 15:05 janetournois

After the clipping I still see the segments of the selection. Is that expected? When I save and reload after clipping we obtain what we expect, so it is probably a cleanup in the selection item which is needed.

image

afabri avatar May 13 '25 15:05 afabri