cgal icon indicating copy to clipboard operation
cgal copied to clipboard

New package: Frechet Distance

Open lrineau opened this issue 1 year ago • 34 comments

Summary of Changes

Add a new package computing the approximate Fréchet distance between two polylines in dD under Euclidean metric, or decides if the distance is smaller than a given value.

Release Management

  • Affected package(s): Frechet_distance
  • Feature/Small Feature (if any): link
  • Link to compiled documentation: link
  • License and copyright ownership: MPI, GeometryFactory, cnrs(?)

TODO:

  • [ ] check branch size (@sloriot)

lrineau avatar Jun 12 '24 13:06 lrineau

/build:v0

afabri avatar Jun 14 '24 12:06 afabri

There was an error while building the doc:

/home/runner/work/cgal/cgal/Documentation/doc/Documentation/packages.txt:341: warning: image file name pkg-small.png is ambiguous.
Possible candidates:
   /home/runner/work/cgal/cgal/Documentation/doc/Documentation/fig/pkg-small.png
   /home/runner/work/cgal/cgal/Polyline_distance/doc/Polyline_distance/fig/pkg-small.png
   /home/runner/work/cgal/cgal/Polygonal_surface_reconstruction/doc/Polygonal_surface_reconstruction/fig/pkg-small.png
   /home/runner/work/cgal/cgal/Weights/doc/Weights/fig/pkg-small.png
   /home/runner/work/cgal/cgal/Cone_spanners_2/doc/Cone_spanners_2/fig/pkg-small.png

https://github.com/CGAL/cgal/actions/runs/9516169288

github-actions[bot] avatar Jun 14 '24 12:06 github-actions[bot]

/force-build:v0

afabri avatar Jun 14 '24 13:06 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jun 14 '24 13:06 github-actions[bot]

/force-build:v0

afabri avatar Jun 14 '24 14:06 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jun 14 '24 14:06 github-actions[bot]

/force-build:v0

afabri avatar Jun 18 '24 08:06 afabri

There was an error while building the doc:

/home/runner/work/cgal/cgal/Frechet_distance/doc/Frechet_distance/Frechet_distance.txt:54: warning: unable to resolve reference to 'Frechet_distance/Frechet_distance_3.cpp' for \ref command

https://github.com/CGAL/cgal/actions/runs/9561793227

github-actions[bot] avatar Jun 18 '24 08:06 github-actions[bot]

/force-build:v0

afabri avatar Jun 18 '24 08:06 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jun 18 '24 09:06 github-actions[bot]

/force-build:v0

afabri avatar Jun 18 '24 09:06 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jun 18 '24 09:06 github-actions[bot]

/force-build:v0

afabri avatar Jun 18 '24 09:06 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jun 18 '24 09:06 github-actions[bot]

/force-build:v0

afabri avatar Jun 19 '24 14:06 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jun 19 '24 14:06 github-actions[bot]

/force-build:v0

afabri avatar Jun 19 '24 16:06 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jun 19 '24 16:06 github-actions[bot]

/force-build:v0

afabri avatar Jul 16 '24 19:07 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jul 16 '24 19:07 github-actions[bot]

/force-build:v0

afabri avatar Jul 16 '24 19:07 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jul 16 '24 19:07 github-actions[bot]

/force-build:v0

afabri avatar Jul 17 '24 01:07 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jul 17 '24 01:07 github-actions[bot]

/force-build:v0

afabri avatar Jul 27 '24 01:07 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v0/Manual/index.html

github-actions[bot] avatar Jul 27 '24 01:07 github-actions[bot]

Working on the dD case I realize that Difference_of_points_d and Construct_vector_3 construct opposite vectors. The functor Construct_vector_d has no operator for two points, and Kernel_23 has no Difference_of_points_2/3. In which direction shall we unify @mglisse @sloriot ?

afabri avatar Sep 17 '24 13:09 afabri

Working on the dD case I realize that Difference_of_points_d and Construct_vector_3 construct opposite vectors. The functor Construct_vector_d has no operator for two points, and Kernel_23 has no Difference_of_points_2/3. In which direction shall we unify @mglisse @sloriot ?

I am ok with either option.

Internally (Construct_LA_vector), I don't want to add more overloading. But in Kernel_d_interface.h, I don't mind turning Construct_vector_d into a wrapper, like we did for Construct_point_d so it could take a weighted point.

mglisse avatar Sep 17 '24 16:09 mglisse

/build:v1

afabri avatar Sep 20 '24 13:09 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html

github-actions[bot] avatar Sep 20 '24 13:09 github-actions[bot]