cgal icon indicating copy to clipboard operation
cgal copied to clipboard
verified publisher icon CGAL

SMS: Make Lindstrom Turk placement more robust

Open afabri opened this issue 1 year ago • 3 comments

Summary of Changes

Reduced data set to illustrate Issue #8213. The collapse of edge v1-v2 results in a completely wrong placement of the vertex.

image

The next step is to make the placement robust.

Release Management

  • Affected package(s): Surface_mesh_simplification.
  • Issue(s) solved (if any): fix #8213
  • License and copyright ownership: unchanged

afabri avatar May 29 '24 08:05 afabri

For the moment this PR adds only a test. You probably forgot to commit/push the actual fix.

lrineau avatar May 29 '24 09:05 lrineau

The next step is to make the placement robust.

I missed that part. I have turned this into a draft PR, and added a https://github.com/CGAL/cgal/labels/TODO label, to avoid this bug-fix PR be merged by accident.

lrineau avatar May 29 '24 09:05 lrineau

We could even add it to the testsuite so that the error shows up.

afabri avatar May 29 '24 09:05 afabri

@MaelRL @LeoValque note that there are already functions called diff_of_products here in the Distance_3 package.

afabri avatar May 22 '25 14:05 afabri

Successfully tested in CGAL-6.1-Ic-189

sloriot avatar Jul 07 '25 18:07 sloriot

Before merging, it would be good id @LeoValque looked into my comment about my comment about diff_of_products.

afabri avatar Jul 08 '25 07:07 afabri

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar Jul 15 '25 16:07 github-actions[bot]

Successfully tested in CGAL-6.1-Ic-208

sloriot avatar Jul 31 '25 13:07 sloriot