cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Published 20 hours ago • verified publisher icon CGAL

Rename parameters

Open sloriot opened this issue 1 year ago • 6 comments

Fixes #8176

sloriot avatar May 02 '24 12:05 sloriot

Wouldn't it be more consistent to replace all NamedParametersOut... by NPOut... in this package? Analogous for NamedParametersIn... rename to NPIn... and NamedParameters... to NP....

albert-github avatar May 02 '24 13:05 albert-github

/build:fix-v1

lrineau avatar May 02 '24 13:05 lrineau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8178/fix/Manual/index.html

github-actions[bot] avatar May 02 '24 13:05 github-actions[bot]

That is better. Now it fits just in the width of my screen: https://cgal.github.io/8178/fix/Polygon_mesh_processing/group__PMP__corefinement__grp.html#gae3553532387bd3ecfbcb72f4f092c7bc

lrineau avatar May 02 '24 13:05 lrineau

Wouldn't it be more consistent to replace all NamedParametersOut... by NPOut... in this package? Analogous for NamedParametersIn... rename to NPIn... and NamedParameters... to NP....

I don't have a strong opinion. I'll have to go through the logs of the review to check if that was a request from the reviewers.

sloriot avatar May 02 '24 14:05 sloriot

It should also be changed for the input parameters.

afabri avatar May 02 '24 14:05 afabri

Successfully tested in CGAL-6.0-Ic-237

sloriot avatar May 10 '24 06:05 sloriot