CGAL
Making the Spherical Guassian-map polyhedron a proper model of FaceGraph
Summary of Changes
The old code does not compile. While the interface is not published, people may still search and find this piece of code, so better have it right.
Release Management
- Affected package(s):
- Issue(s) solved (if any): na
- Feature/Small Feature (if any): na
- Link to compiled documentation : na
- License and copyright ownership: TAU
@efifogel does it make sense to have a test compiling it, just to make sure it is not broken at some point?
Sure, I'll add one.
/_____/) o /_________ __ // (____ ( ( ( (/ (/-(-'_(/ _/
On Mon, 22 Apr 2024 at 09:41, Sebastien Loriot @.***> wrote:
@efifogel https://github.com/efifogel does it make sense to have a test compiling it, just to make sure it is not broken at some point?
— Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/pull/8153#issuecomment-2068603026, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBNOHFDOJSPWMZYLAZLQDY6SWJTAVCNFSM6AAAAABGQSOSP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGYYDGMBSGY . You are receiving this because you were mentioned.Message ID: @.***>
ok, did that (added some code to test that it compiles). PS, in the near future I plan to submit a new feature (or at least a small feature) that publishes this code (Gaussian map, a.k.a. normal diagram, of a convex polyhedron).
/_____/) o /_________ __ // (____ ( ( ( (/ (/-(-'_(/ _/
On Mon, 22 Apr 2024 at 10:41, Efi Fogel @.***> wrote:
Sure, I'll add one.
/_____/) o /_________ __ // (____ ( ( ( (/ (/-(-'_(/ _/
On Mon, 22 Apr 2024 at 09:41, Sebastien Loriot @.***> wrote:
@efifogel https://github.com/efifogel does it make sense to have a test compiling it, just to make sure it is not broken at some point?
— Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/pull/8153#issuecomment-2068603026, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBNOHFDOJSPWMZYLAZLQDY6SWJTAVCNFSM6AAAAABGQSOSP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGYYDGMBSGY . You are receiving this because you were mentioned.Message ID: @.***>