cgal icon indicating copy to clipboard operation
cgal copied to clipboard

PMP::isotropic_remeshing() - add NP `allow move functor`

Open janetournois opened this issue 1 year ago • 2 comments

Summary of Changes

The function tangential_relaxation() has a named parameter called allow_move_functor that enables the user to prevent and cancel some vertex moves.

With this PR, it is now possible to use the same parameter for the relaxation steps of CGAL::Polygon_mesh_processing::isotropic_remeshing()

Release Management

  • Affected package(s): PMP
  • Issue(s) solved (if any): partially solves issue #8134
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: unchanged

janetournois avatar Apr 18 '24 11:04 janetournois

To solve #8134, we can think of a smart functor that would prevent self-intersections from being introduced by the relaxation step

janetournois avatar Apr 18 '24 11:04 janetournois

Successfully tested in CGAL-6.0-Ic-235

sloriot avatar May 06 '24 07:05 sloriot

To solve #8134, we can think of a smart functor that would prevent self-intersections from being introduced by the relaxation step

Should we close the issue #8134, how that this PR is merged, or leave it open? Because it seems the actual solution to #8134 is

  • this PR #8150,
  • plus something else (see the quote above).

lrineau avatar May 16 '24 10:05 lrineau

I will post a possible functor in the issue soon! Thanks for assigning it to me

janetournois avatar May 16 '24 15:05 janetournois