cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Use light mode in the doc by default

Open sloriot opened this issue 1 year ago • 1 comments
trafficstars

sloriot avatar Mar 27 '24 07:03 sloriot

Successfully tested in CGAL-6.0-Ic-209

sloriot avatar Apr 04 '24 09:04 sloriot

See also what I have done in another PR: commit https://github.com/CGAL/cgal/commit/6a45cc9f66ef3672eb290e3ee55a9425f632526b.

The result is a cgal_stylesheet.css that seems compatible with light, dark, and print modes.

Screencast_20240701_165445.webm

lrineau avatar Jul 01 '24 14:07 lrineau

@lrineau I don't know what you intended with your comment https://github.com/CGAL/cgal/pull/8100#issuecomment-2200393723

  1. I don't think the changes in the css should be hidden in PR #8186 but should be in a PR of their own.
  2. What setting did you use for the HTML_COLORSTYLE? or did you use the default setting AUTO_LIGHT?
  3. Why setting just one color and not the way doxygen does it (see https://github.com/doxygen/doxygen/tree/master/templates/html directory and also https://github.com/doxygen/doxygen/blob/master/doc/doxygen_manual.cssfile
  4. I see that you use the property background why not use background-color as background sets / influences not only background-color but also e.g. background-image etc

albert-github avatar Jul 01 '24 15:07 albert-github