cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Fix implicit gmp to double conversion failures

Open pentacular opened this issue 1 year ago • 3 comments

Please use the following template to help us managing pull requests.

Summary of Changes

Trivial fix for errors in compiling isotropic remeshing using gmp which fails to convert implicitly to double.

Release Management

  • Affected package(s):
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

pentacular avatar Mar 19 '24 02:03 pentacular

@sloriot would it make sense to add a test that checks that isotropic remeshing compiles with GMP?

janetournois avatar Mar 22 '24 09:03 janetournois

do you think it would work to have double -> FT? From what I remember we said it would not be a good idea. Note also that with a specific vertex point map (on-the-fly conversion), this patch would not be needed.

sloriot avatar Mar 22 '24 09:03 sloriot