cgal icon indicating copy to clipboard operation
cgal copied to clipboard

New function `PMP::add_bbox(face_graph)` that adds bbox to face graph

Open janetournois opened this issue 1 year ago • 6 comments

Summary of Changes

the bbox can be :

  • triangulated or not
  • tight or not

Release Management

  • Affected package(s): PMP
  • Feature/Small Feature : wiki
  • Link to compiled documentation add_bbox()
  • License and copyright ownership: unchanged

janetournois avatar Feb 06 '24 11:02 janetournois

/build:v0

janetournois avatar Feb 12 '24 15:02 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v0/Manual/index.html

github-actions[bot] avatar Feb 12 '24 15:02 github-actions[bot]

/force-build:v0

janetournois avatar Feb 13 '24 13:02 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v0/Manual/index.html

github-actions[bot] avatar Feb 13 '24 13:02 github-actions[bot]

/force-build:v0

janetournois avatar Feb 13 '24 14:02 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v0/Manual/index.html

github-actions[bot] avatar Feb 13 '24 15:02 github-actions[bot]

Successfully tested in CGAL-6.0-Ic-181 (at least compilation as there is no runtime checks)

sloriot avatar Feb 28 '24 09:02 sloriot

This PR is tested, but there are still open discussions:

  • https://github.com/CGAL/cgal/pull/8018#discussion_r1499279561
  • https://github.com/CGAL/cgal/pull/8018#discussion_r1502947602

lrineau avatar Feb 28 '24 09:02 lrineau

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar Mar 04 '24 16:03 github-actions[bot]

/build:v1

janetournois avatar Mar 05 '24 11:03 janetournois

There was an error while building the doc:

/home/runner/work/cgal/cgal/BGL/include/CGAL/boost/graph/generators.h:359: warning: The following parameters of CGAL::make_hexahedron(const IsoCuboid &c, Graph &g, const NamedParameters &np=parameters::default_values()) are not documented:
  parameter 'c'
  parameter 'g'

https://github.com/CGAL/cgal/actions/runs/8155624993

github-actions[bot] avatar Mar 05 '24 11:03 github-actions[bot]

/force-build:v1

janetournois avatar Mar 05 '24 13:03 janetournois

There was an error while building the doc:

/home/runner/work/cgal/cgal/BGL/include/CGAL/boost/graph/generators.h:359: warning: The following parameters of CGAL::make_hexahedron(const IsoCuboid &c, Graph &g, const NamedParameters &np=parameters::default_values()) are not documented:
  parameter 'c'
  parameter 'g'

https://github.com/CGAL/cgal/actions/runs/8157154353

github-actions[bot] avatar Mar 05 '24 13:03 github-actions[bot]

/force-build:v1

janetournois avatar Mar 05 '24 13:03 janetournois

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v1/Manual/index.html

github-actions[bot] avatar Mar 05 '24 13:03 github-actions[bot]

@sloriot @MaelRL please review my last commit

The include at the end of helpers.h was introduced by 05285920114e53e1347cd980a91d4480963337b2 (in 2019) for backward compatibility. I think it can now be removed and this way avoid fwd declarations in generators.h

janetournois avatar Mar 06 '24 09:03 janetournois

tests failing in CGAL-6.0-Ic-191 (BGL for example)

sloriot avatar Mar 12 '24 07:03 sloriot

Successfully tested in 6.0-Ic-197

sloriot avatar Mar 21 '24 09:03 sloriot