New function `PMP::add_bbox(face_graph)` that adds bbox to face graph
Summary of Changes
the bbox can be :
- triangulated or not
- tight or not
Release Management
- Affected package(s): PMP
- Feature/Small Feature : wiki
- Link to compiled documentation add_bbox()
- License and copyright ownership: unchanged
/build:v0
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v0/Manual/index.html
/force-build:v0
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v0/Manual/index.html
/force-build:v0
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v0/Manual/index.html
Successfully tested in CGAL-6.0-Ic-181 (at least compilation as there is no runtime checks)
This PR is tested, but there are still open discussions:
- https://github.com/CGAL/cgal/pull/8018#discussion_r1499279561
- https://github.com/CGAL/cgal/pull/8018#discussion_r1502947602
This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.
/build:v1
There was an error while building the doc:
/home/runner/work/cgal/cgal/BGL/include/CGAL/boost/graph/generators.h:359: warning: The following parameters of CGAL::make_hexahedron(const IsoCuboid &c, Graph &g, const NamedParameters &np=parameters::default_values()) are not documented:
parameter 'c'
parameter 'g'
https://github.com/CGAL/cgal/actions/runs/8155624993
/force-build:v1
There was an error while building the doc:
/home/runner/work/cgal/cgal/BGL/include/CGAL/boost/graph/generators.h:359: warning: The following parameters of CGAL::make_hexahedron(const IsoCuboid &c, Graph &g, const NamedParameters &np=parameters::default_values()) are not documented:
parameter 'c'
parameter 'g'
https://github.com/CGAL/cgal/actions/runs/8157154353
/force-build:v1
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v1/Manual/index.html
@sloriot @MaelRL please review my last commit
The include at the end of helpers.h was introduced by 05285920114e53e1347cd980a91d4480963337b2 (in 2019) for backward compatibility. I think it can now be removed and this way avoid fwd declarations in generators.h
tests failing in CGAL-6.0-Ic-191 (BGL for example)
Successfully tested in 6.0-Ic-197