cgal icon indicating copy to clipboard operation
cgal copied to clipboard
verified publisher icon CGAL

IO: write_PLY() for Epeck

Open afabri opened this issue 2 years ago • 14 comments

Summary of Changes

As reported in #7868 the function CGAL::IO::write_PLY() used in binary mode does not correctly write the coordinates if the points are from a kernel with exact constructions.
~~This PR applies `to_double()" to the coordinates.~~

After a discussion with @MaelRL we decided that the user is in charge to pass a vertex_point_map as named parameter that does the conversion. This is straightforward as we offer the Cartesian_converter_property_map.

As the problem is the same for the vertex normals we add a named parameter vertex_normal_map.

Todo

  • [ ] Fix the generic function write_polygon_mesh(). Currently it is fixed for Surface_mesh

Release Management

  • Affected package(s): Stream_support
  • Issue(s) solved (if any): fix #7868 and fix https://github.com/CGAL/cgal/issues/7327
  • License and copyright ownership: unchanged

afabri avatar Nov 20 '23 13:11 afabri

BGL tests failing in CGAL-6.0-Ic-112

sloriot avatar Nov 22 '23 07:11 sloriot

Successfully tested in CGAL-6.0-Ic-116

sloriot avatar Nov 29 '23 08:11 sloriot

@afabri There is still an undone TODO in the top message of this other PR. Do you want this PR merged as it is?

lrineau avatar Nov 29 '23 15:11 lrineau

@afabri There is still an undone TODO in the top message of this other PR. Do you want this PR merged as it is?

No, I still want to fix the generic code.

afabri avatar Nov 29 '23 15:11 afabri

@afabri any chance you can fix that today (if inclusion in 5.6.1 is needed)?

sloriot avatar Dec 14 '23 09:12 sloriot

@afabri, this PR was marked tested 2 month ago and is still waiting for a TODO. Maybe you want to open an issue instead and integrate the PR.

sloriot avatar Jan 24 '24 13:01 sloriot

Ping @afabri

lrineau avatar May 28 '24 06:05 lrineau

Ping @afabri

Will be treated somewhere in the future.

afabri avatar May 28 '24 15:05 afabri

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar Jun 07 '24 07:06 github-actions[bot]

/build:v0

afabri avatar Jun 11 '24 14:06 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7874/v0/Manual/index.html

github-actions[bot] avatar Jun 11 '24 14:06 github-actions[bot]