cgal icon indicating copy to clipboard operation
cgal copied to clipboard

GSoC2023 - ACVD for Simplification & Remeshing

Open hoskillua opened this issue 2 years ago • 3 comments

Release Management

  • Affected package(s): PMP (to be separated)
  • Issue: https://github.com/CGAL/cgal/issues/7852
  • Feature/Small Feature (if any): Approximated Centroidal Voronoi Diagrams for Simplification & Remeshing(GSoC2023-WIP)

TODO

  • [x] remove commit introducing interpolated_corrected_curvatures.h after the merge of the gsoc2022 branch
  • [ ] remove qem_metrics.h and types.h from history (for @sloriot)
  • [ ] check branch size (for @sloriot)
  • [x] handle interpolated curvature update (for @sloriot)
  • [ ] debug the QEM minimization implementation (for @hoskillua)
  • [ ] test the other versions as possibly some cases produce bad results (for @hoskillua)
  • [ ] code cleanup (especially the logic for computing energy difference on edge and moving an element for @hoskillua )
  • [ ] recompute the energy after each convergence (for @hoskillua)

hoskillua avatar Oct 31 '23 07:10 hoskillua

Note that I updated the interpolated curvature branch I'll handle the update of that PR once the other branch is merged in master.

sloriot avatar Nov 13 '23 17:11 sloriot

What are the next steps for this package?
Is it complete and is it bug free, and basically needs just a submission as (small?) feature?
I noticed that there is no testsuite. And also Eigen is hardwired and not a model of a Solver concept. Does what is done here correspond to an existing Solver concept?

afabri avatar Jun 07 '24 11:06 afabri

What are the next steps for this package? Is it complete and is it bug free, and basically needs just a submission as (small?) feature? I noticed that there is no testsuite. And also Eigen is hardwired and not a model of a Solver concept. Does what is done here correspond to an existing Solver concept?

Unfortunately, it is not. I didn't get the chance to get into it in the past month but I am planning to work more on it later this month. Sorry for being late on that.

hoskillua avatar Jun 10 '24 09:06 hoskillua