cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Fix example mesh_3D_gray_vtk_image

Open ange-clement opened this issue 2 years ago • 5 comments

Summary of Changes

Fixes example mesh_3D_gray_vtk_image. Changed : Meshing all value under isovalue --> Meshing all values over isovalue.

Release Management

  • Affected package(s): Mesh_3
  • Issue(s) solved (if any):
  • Feature/Small Feature (if any): n/a
  • License and copyright ownership: no change

ange-clement avatar Oct 24 '23 15:10 ange-clement

Successfully tested in CGAL-6.0-Ic-122

sloriot avatar Dec 07 '23 08:12 sloriot

@janetournois @ange-clement As far as I understand, that pull-request is debated. I will not merge it, even if it was tested successfully.

lrineau avatar Dec 07 '23 10:12 lrineau

@janetournois what is the status of this PR?

sloriot avatar Dec 14 '23 09:12 sloriot

This modifies the example of Mesh_3 to make it work with different data sets, and it does not bring any new info or feature, so imho it can be closed.

janetournois avatar Dec 14 '23 10:12 janetournois

What about adding an option in the parameter to pick less or more?

sloriot avatar Dec 18 '23 12:12 sloriot