cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Mesh 3 - Triangulation IO and Save and load C3t3 features

Open ange-clement opened this issue 2 years ago • 7 comments

Summary of Changes

Enable writing and reading of 1D features (edges) of Mesh_complex_3_in_triangulation_3. The Triangulation_3 writing and loading have been moved to CGAL::IO::export_triangulation_3 and CGAL::IO::import_triangulation_3

Tasks:

  • [x] Move Triangulation_3 writing and loading (operator<</>>)
  • [x] Make Triangulation_3::file_input use the writing and loading (remove duplicated code)
  • [x] Add 1D features to polyhedron demo

Release Management

  • Affected package(s): Mesh_3
  • Issue(s) solved (if any): fix #7780 , related to #2359 , similar to #5151
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

ange-clement avatar Oct 23 '23 13:10 ange-clement

@lrineau @janetournois This PR is ready to be reviewed.

ange-clement avatar Nov 07 '23 16:11 ange-clement

Runtime error: https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-177/SMDS_3/TestReport_lrineau_ArchLinux-clang-CXX20-Release.gz

sloriot avatar Feb 21 '24 10:02 sloriot

Funny thing is that only https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-177/SMDS_3/TestReport_lrineau_Fedora-32.gz does not have the runtime error.

sloriot avatar Feb 21 '24 10:02 sloriot

@janetournois @sloriot This PR is ready to be reviewed and tested.

ange-clement avatar Apr 04 '24 15:04 ange-clement

Funny thing is that only https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-177/SMDS_3/TestReport_lrineau_Fedora-32.gz does not have the runtime error.

Yes, there is a test that is not performed on 32 bits architectures.

ange-clement avatar Apr 04 '24 15:04 ange-clement

@ange-clement could you please fix the merge conflict?

sloriot avatar May 06 '24 12:05 sloriot

Test failing in 6.0-Ic-305

See here

sloriot avatar Aug 13 '24 15:08 sloriot