cgal icon indicating copy to clipboard operation
cgal copied to clipboard

The (Polygon) Partition traits polygon-definition is erroneous

Open efifogel opened this issue 2 years ago • 1 comments

The Partition_traits_2 traits module explicitly defines the Polygon_2 type to use std::list for storing the points of the polygon; see Line 65:

typedef ::std::list<Point_2> Container;

This, naturally, prevents the use of the traits with a polygon defined with a different container, e.g., vector... The template Partition_traits_2 must accept the type of container as an addition template parameter.

Environment

  • Operating system (Windows/Mac/Linux, 32/64 bits): all
  • Compiler: all
  • Release or debug mode: both
  • Specific flags used (if any): irrelevant
  • CGAL version: recent
  • Boost version: irrelevant
  • Other libraries versions if used (Eigen, TBB, etc.): none

efifogel avatar Jun 25 '23 06:06 efifogel

Just a remark and not yet a fix: This does not concern the input which is only a range of points in an arbitrary container, but only the output.

afabri avatar Jul 28 '23 13:07 afabri