CGAL
STL extension: Add a template argument to Prevent_deref for the value type
Summary of Changes
Fix issue #7400
Release Management
-
Affected package(s): Triangulation_2, Triangulation_3, STL_extension
-
Issue(s) solved (if any): fix #7400
-
License and copyright ownership: unchanged
This is most likely responsible for runtime errors in Shape_detection in CGAL-5.6-Ic-271.
might be related commits:
- https://github.com/CGAL/cgal/pull/6702/commits/427e147c7f7e8f681cc762efa14e6ab6ac0d0364
- https://github.com/CGAL/cgal/pull/6702/commits/7c4123152b61c97613332973dc199644a4e625ab (later reverted by 2e0bc5ec996531d83b865a4633b62d18207c10c5)
- https://github.com/CGAL/cgal/pull/6702/commits/15b55bd32f11ff39e45c660c9fe07eab68856029
Note that I also suspect that it is responsible for the many time out in PMP. From what I remember, I did try a similar change and it has a dramatic impact on the runtime of Polyhedron (see also 2e0bc5ec996531d83b865a4633b62d18207c10c5).
@sloriot I have removed the https://github.com/CGAL/cgal/labels/Tests%20failing label, because the corresponding tests were three months ago, and the pull-request has changed since then.
I suspect this PR to be responsible for Shape detection runtime errors in CGAL-6.0-Ic-114.
The address sanitizer found stack-use-after-scope errors: https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-114/Shape_detection/TestReport_lrineau_Fedora-Release.gz
This PR has both labels "Tests failing" and "Ready to be tested"....(?)
This PR has both labels "Tests failing" and "Ready to be tested"....(?)
This PR #7410 is on my personal TODO-list. It is a blocker for #8170.