cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Mesh_3 - crash in test

Open janetournois opened this issue 2 years ago • 3 comments

Issue Details

The test test_meshing_3D_gray_image_deprecated.cpp fails with seed CGAL::get_default_random() = CGAL::Random(1681938963);

It is visible here

Environment

  • Compiler: MSVC 2022 (at least)
  • Release or debug mode: debug
  • CGAL version: master
  • Boost version: 1.80

janetournois avatar Apr 24 '23 14:04 janetournois

With the seed, I can reproduce the bug with master (5.6-dev), but also 5.5, 5.4, 5.3, 5.2, 5.1. And then I gave up because with 5.0 I got a CMake error.

So, that is an old bug, revealed by that seed.

lrineau avatar Apr 24 '23 14:04 lrineau

Can we also produce the bug with non-deprecated code?

afabri avatar Jul 26 '23 12:07 afabri

I just made some experiments. Both test_meshing_3D_gray_image and test_meshing_3D_gray_image_deprecated were failing with the seed 1681938963 in CGAL-5.5.2. None of them is failing in CGAL-5.6-beta1.

It would be good that someone on another platform gives it a try before we close this issue, but it seems it has been fixed! If we want to backport the fix, we need to find what commit(s) has fixed it.

janetournois avatar Jul 27 '23 13:07 janetournois

I can reproduce the error with 5.5.x branch with the seed for test_meshing_3D_gray_image_deprecated and with 5.6.x-branch. The test is gone in master but it is still present in 97097f1f040472b2fa8b02d778ecb22b55109d05 that the commit before the removal of the test. test_meshing_3D_gray_image works with the seed in the two release branches and master.

@janetournois @MaelRL can we discuss it quickly this afternoon?

sloriot avatar Aug 13 '24 09:08 sloriot

Actually we can reproduce the error with master and test_meshing_3D_gray_image by adding facet_topology = CGAL::MANIFOLD to Mesh_criteria.

Looking in the log, the following commit:

commit f7a48360395d819bbd15b48071bd89fc0bdd9648
Author: Laurent Rineau <[email protected]>
Date:   Tue May 21 13:43:11 2019 +0200

    Do not deactivate all topological criteria

is actually removing that line from the criteria.

Backported in #8409

sloriot avatar Aug 13 '24 14:08 sloriot