CGAL
Replaced call to Arrangement_on_surface_2::traits() with geometry_traits() and cleaned up
This is a small fix that replaces the call to the member traits() of Arrangement_on_surface_2 with the call geometry_traits(). This is another step in utilizing the trapezoidal decomposition point-location location strategy for arrangements on spheres.
Release Management
- Affected package(s): Arrangement_on_surface_2
- Issue(s) solved (if any): NA
- Feature/Small Feature (if any): NA
- Link to compiled documentation: NA
- License and copyright ownership: TA univ
ok, this is fixed now; thanks.
/_____/) o /_________ __ // (____ ( ( ( (/ (/-(-'_(/ _/
On Tue, 6 Sept 2022 at 16:35, Sebastien Loriot @.***> wrote:
@.**** commented on this pull request.
In Arrangement_on_surface_2/include/CGAL/Arr_point_location/Arr_trapezoid_ric_pl_impl.h https://github.com/CGAL/cgal/pull/6810#discussion_r963717260:
// If the closest feature is a valid halfedge, take its incident face. // Otherwise, take the unbounded face.
- if (halfedge_found == invalid_he)
- face = _get_unbounded_face(tr, p, All_sides_oblivious_category());
- else
- Face_const_handle face = (halfedge_found == invalid_he) ?
This triggers a new warning: Arrangement_on_surface_2/TestReport_lrineau_Ubuntu-GCC_master_CXX20-Release.gz:/mnt/testsuite/include/CGAL/Arr_point_location/Arr_trapezoid_ric_pl_impl.h:339:21: warning: operation on 'face' may be undefined [-Wsequence-point]
— Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/pull/6810#pullrequestreview-1097603788, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBNOETCTAZZXJASQ3WRYDV45CBRANCNFSM57TXMY6Q . You are receiving this because you authored the thread.Message ID: @.***>
Added back an explicit definition of an isolated-vertex iterator (without 'auto') to pacify MSVC. Please try again. Thanks.
/_____/) o /_________ __ // (____ ( ( ( (/ (/-(-'_(/ _/
On Wed, 28 Sept 2022 at 09:34, Sebastien Loriot @.***> wrote:
This one seems to be failing too on windows. See here https://cgal.geometryfactory.com/CGAL/Members/testsuite/CGAL-5.6-Ic-78/Arrangement_on_surface_2/TestReport_Christo_MSVC2017-Debug-64bits.gz and there https://cgal.geometryfactory.com/CGAL/Members/testsuite/CGAL-5.6-Ic-78/Arrangement_on_surface_2_Examples/TestReport_Christo_MSVC2017-Debug-64bits.gz for example.
— Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/pull/6810#issuecomment-1260452124, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBNOA6KWV6GC7TCOG3EO3WAPRINANCNFSM57TXMY6Q . You are receiving this because you authored the thread.Message ID: @.***>