CGAL
Polyhedron demo - fix display of protecting balls
Summary of Changes
On some setups (including mine), the protecting balls for a C3t3 could not be displayed anymore in the demo. This PR attempts to fix the display of protecting balls.
The regression was introduced by PR #5809 by the set of commits :
- e5914cf70fcd231cd0930f7ab1564b05e4013edc (the first bad wrt displaying protecting balls, that compiles and displays the C3t3 properly)
- 4f9fc89a10651c087083a66026a9c5f4c49c7c17
- 73eafddd39b595c1cb0cfcd862104551c748eb4f
- 2c36a1797cbec4dde5f0e08180d4c0e6a593e097
- last good was : ec41af7e33af779082dadd93bd3816a4c8e9ca52
My patch does not fix the code introduced by these commits, but disables the "c3t3 spheres" shader.
Release Management
- Affected package(s): Polyhedron demo
- License and copyright ownership: unchanged
With commit b98ac1a0bbec, the protecting balls are displayed but they do not take the cut plane into account. All of them are displayed.
When opening a C3t3 with protecting balls, these errors repeat several times in the log:
GL ERROR : (ShaderCompilerSource : ErrorType)
SHADER_ID_LINK error has been generated. GLSL link failed for program 24, "": The ♦ shader uses varying subdomain_out, but previous
shader does not write to it.
Out of resource error.
QOpenGLShader::link: The ♦ shader uses varying subdomain_out, but previous shader does not write to it.
Out of resource error.
GL ERROR : (ShaderCompilerSource : ErrorType)
SHADER_ID_LINK error has been generated. GLSL link failed for program 24, "": The ♦ shader uses varying subdomain_out, but previous
shader does not write to it.
Out of resource error.
QOpenGLShader::link: The ♦ shader uses varying subdomain_out, but previous shader does not write to it.
Out of resource error.
QOpenGLShaderProgram::attributeLocation(colors): shader program is not linked
QOpenGLShaderProgram::attributeLocation(vertex): shader program is not linked
QOpenGLShaderProgram::attributeLocation(vertex): shader program is not linked
QOpenGLShaderProgram::attributeLocation(normals): shader program is not linked
QOpenGLShaderProgram::attributeLocation(normals): shader program is not linked
QOpenGLShaderProgram::attributeLocation(colors): shader program is not linked
QOpenGLShaderProgram::attributeLocation(colors): shader program is not linked
QOpenGLShaderProgram::attributeLocation(center): shader program is not linked
QOpenGLShaderProgram::attributeLocation(center): shader program is not linked
QOpenGLShaderProgram::attributeLocation(radius): shader program is not linked
QOpenGLShaderProgram::attributeLocation(radius): shader program is not linked
@lrineau replaced?
Yes, as soon as Jane confirms that the PR https://github.com/CGAL/cgal/pull/6863 is a correct solution.
