cgal icon indicating copy to clipboard operation
cgal copied to clipboard
verified publisher icon CGAL

Triangulation_2: Don't insert segment twice

Open afabri opened this issue 3 years ago • 12 comments

Summary of Changes

Inserting a segment as constraint more than once may cause problems when there are intersections. This PR addresses it in the insert_constraints() function.
We might add a bool parameter in the API to document this.

Release Management

  • Affected package(s): Triangulation_2
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any): https://cgalwiki.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Triangulation_2:_remove_duplicates_constraints
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

afabri avatar May 19 '22 11:05 afabri

/build:v0

afabri avatar May 19 '22 21:05 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6595/v0/Manual/index.html

github-actions[bot] avatar May 19 '22 21:05 github-actions[bot]

Successfully tested in CGAL-5.5-Ic-92

sloriot avatar May 26 '22 15:05 sloriot

I'm fine with the new API introduced. @lrineau Do we need a small feature?

sloriot avatar Jun 16 '22 12:06 sloriot

I'm fine with the new API introduced. @lrineau Do we need a small feature?

It is not me to decide. That depends if you want to follow the rules of the CGAL project.

Know that I am opposed to API using bool parameters. It should be a named parameter, or an enum.

lrineau avatar Jun 17 '22 07:06 lrineau

This PR seems useful, @afabri what is its status?

sloriot avatar Jan 30 '23 13:01 sloriot

ping @afabri

sloriot avatar Apr 06 '23 16:04 sloriot