CGAL
Minimal angle remeshing
Summary of Changes
Implemented the algorithm, documentation and plugin of minimal_angle_remeshing.
Release Management
- Affected package(s): Polygon Mesh Processing
- Issue(s) solved (if any): None
- Feature/Small Feature (if any): None
- Link to compiled documentation (obligatory for small feature) wrong link name to be changed
- License and copyright ownership: INRIA Sophia-Antipolis (France)
Hi Kaimo, the issue in the check is that it seems that Surface_mesh is hard coded as mesh data structure in the new meshing function. This introduces a new dependency for the PMP package. I'll have a look if it is not too much work to remove it.
In the meantime, it would be great if you can update the user manual (Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt) and add a section about the new method. In particular, there should also be a section that is describing in which case the new function should be used over isotropic_remeshing() and the converse. This would make things clearer for the users of the library.
Hi Kaimo, the issue in the check is that it seems that
Surface_meshis hard coded as mesh data structure in the new meshing function. This introduces a new dependency for the PMP package. I'll have a look if it is not too much work to remove it.In the meantime, it would be great if you can update the user manual (
Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt) and add a section about the new method. In particular, there should also be a section that is describing in which case the new function should be used overisotropic_remeshing()and the converse. This would make things clearer for the users of the library.
Hi Sebastien, thanks for checking the Surface_mesh issue. Please let me know if you have finished it.
I have updated the user manual (Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt), and commited to the PR. Please let me know if further actions are required from my side.
There was an error while building the doc: warning: tag INPUT: input source `/CGAL/Polygon_mesh_processing/minimal_angle_remeshing.h' does not exist
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
There was an error while building the doc: /home/runner/work/cgal/cgal/Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt:143: warning: cite command to 'hu2017TVCG' does not have an associated number
There was an error while building the doc: warning: tag INPUT: input source `/CGAL/Polygon_mesh_processing/minimal_angle_remeshing.h' does not exist
This problem has been solved.
The documentation is built. It will be available, after a few minutes, here : https://cgal.github.io/5939/v0/Manual/index.html
/build:v0
Hello Sebastien, could you please build the documentation again? I just modified the section minimal_angle_remeshing in the user manual, and would like to see whether it better than before.
There was an error while building the doc: /home/runner/work/cgal/cgal/Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt:108: warning: Found unknown command `subsubsubsection'
There was an error while building the doc: /home/runner/work/cgal/cgal/Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt:108: warning: Found unknown command `subsubsubsection'
Fixed the problem of "found unknown command `subsubsubsection'".
As @maxGimeno pointed out to me, and I agree with him, the doc building command should only be called once a local build with doxygen was succesful. It is more to have the html output directly on github.
The documentation is built. It will be available, after a few minutes, here : https://cgal.github.io/5939/v0/Manual/index.html