add detect sharp corners
Summary of Changes
Adds the function detect_sharp_corners to detect sharp corners as addressed in issue #1708
Release Management
- Affected package(s): PMP
- Issue(s) solved (if any): fix #1708
- Feature/Small Feature (if any): add detect_sharp_corners function
- License and copyright ownership:
In the demo, you should add what is needed to have the sharp corners highlighted, similarly to the way sharp edges are highlighted (see Scene_surface_mesh_item.cpp)
Now vertices incident to 1 or more than 2 sharp edges are set to be "sharp". There are two more cases to handle :
- vertices incident to exactly 2 sharp edges that form a sharp angle together
- vertices incident to no sharp edges and that form a sharp angle (like the tip of a cone)
This PR is very related to #4084 that includes experimental code for features detection
@janetournois still targeting 5.4?
@janetournois still targeting 5.4?
Jane, do we still want it for next release? The code freeze is... supposed to be today.
Sorry I had missed the previous message. There is no small feature yet so let's postpone it to 5.5, and make it complete by then