cgal icon indicating copy to clipboard operation
cgal copied to clipboard

add detect sharp corners

Open kabirkedia opened this issue 4 years ago • 5 comments

Summary of Changes

Adds the function detect_sharp_corners to detect sharp corners as addressed in issue #1708

Release Management

  • Affected package(s): PMP
  • Issue(s) solved (if any): fix #1708
  • Feature/Small Feature (if any): add detect_sharp_corners function
  • License and copyright ownership:

kabirkedia avatar May 14 '21 14:05 kabirkedia

In the demo, you should add what is needed to have the sharp corners highlighted, similarly to the way sharp edges are highlighted (see Scene_surface_mesh_item.cpp)

janetournois avatar May 17 '21 09:05 janetournois

Now vertices incident to 1 or more than 2 sharp edges are set to be "sharp". There are two more cases to handle :

  1. vertices incident to exactly 2 sharp edges that form a sharp angle together
  2. vertices incident to no sharp edges and that form a sharp angle (like the tip of a cone)

This PR is very related to #4084 that includes experimental code for features detection

janetournois avatar Aug 24 '21 14:08 janetournois

@janetournois still targeting 5.4?

sloriot avatar Sep 23 '21 09:09 sloriot

@janetournois still targeting 5.4?

Jane, do we still want it for next release? The code freeze is... supposed to be today.

lrineau avatar Sep 30 '21 15:09 lrineau

Sorry I had missed the previous message. There is no small feature yet so let's postpone it to 5.5, and make it complete by then

janetournois avatar Oct 01 '21 06:10 janetournois