cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Improve 1D feature protection API

Open sloriot opened this issue 5 years ago • 1 comments

Currently there is no easy way to see what the 1D protection algorithm is doing and when it fails (i.e. over-refinement)

An API should be added to run the protection algorithm (doing for example an initialization of c3t3.triangulation()) and that function should return how the protection went. Being able to specifying the minimal size of the ball protection would be nice as it could help now about over-refinement.

Being able to visualize balls would also be interesting, and also ball "in conflict/invalid".

sloriot avatar Nov 18 '20 14:11 sloriot

At the same time, it would be nice to expose the hidden parameters to limit the size of the minimal protecting ball. Having some error code returned would simplify the debugging.

sloriot avatar Sep 13 '21 13:09 sloriot

@janetournois this is partially implemented with min_edge_size, right?

sloriot avatar Feb 07 '25 14:02 sloriot

Indeed, edge_min_size prevents over-refinement by bounding the size of protecting balls from below.

However, there is no return code to know if feature protection has been stopped by this criterion or if it has terminated "normally"

janetournois avatar Feb 17 '25 10:02 janetournois