cgal icon indicating copy to clipboard operation
cgal copied to clipboard

GSoC: Approximate convex decomposition

Open liubsp opened this issue 7 years ago • 12 comments

Summary

Adds the implementation of the algorithm proposed by Khaled Mamou and Faouzi Ghorbel in the paper:

A simple and efficient approach for 3d mesh approximate convex decomposition. Groupe de recherche GRIFT, 2010.

It’s an efficient approach to decompose a concave 3D mesh into a set of nearly convex surfaces and is useful for skeleton extraction, patterns recognition applications and particularly for the increase of collision detection accuracy without significantly affecting its performance.

Release Management

TODO:

  • [x] Update CHANGES.md

liubsp avatar Aug 30 '18 23:08 liubsp

Now Travis sees build failures. See the red results at https://travis-ci.org/CGAL/cgal/builds/437847024

lrineau avatar Oct 08 '18 09:10 lrineau

In addition to the Travis issues, there is a conflict with master, in BGL/test/BGL/test_cgal_bgl_named_params.cpp.

lrineau avatar Oct 08 '18 13:10 lrineau

@CUBERLEON I refreshed the branch and push-force (you need to hard reset your remote).

sloriot avatar Oct 09 '18 12:10 sloriot

Hi, I think the small feature should be accepted by now, and this PR integrated. @CUBERLEON or @sloriot can one of you please resolve the small conflict in CHANGES.md so I can put the branch in integration ?

maxGimeno avatar Jan 10 '19 13:01 maxGimeno

I have fixed the trivial conflict in CHANGES.html. Let's wait for Travis results, and then merge this in integration.

lrineau avatar Jan 10 '19 16:01 lrineau

Warnings in the doc : /home/cgal-testsuite/cgal_doc_build/CGAL-4.14-Ic-96/doc/Surface_mesh_segmentation/PackageDescription.txt:44: warning: explicit link request to 'CGAL::approximate_convex_segmentation()' could not be resolved /home/cgal-testsuite/cgal_doc_build/CGAL-4.14-Ic-96/doc/Surface_mesh_segmentation/PackageDescription.txt:45: warning: explicit link request to 'CGAL::concavity_values()' could not be resolved

maxGimeno avatar Jan 15 '19 13:01 maxGimeno

also errors : https://cgal.geometryfactory.com/CGAL/testsuite/results-4.14-Ic-99.shtml#Surface_mesh_segmentation

maxGimeno avatar Jan 17 '19 07:01 maxGimeno

@CUBERLEON What is your plan for this PR/small feature please?

gdamiand avatar Mar 07 '19 08:03 gdamiand

@gdamiand I'm the one responsible for the delay. I did not have time to look deeply at the code to see if there is a way to speed things up and I did not want to merge it before.

sloriot avatar Mar 07 '19 09:03 sloriot

@sloriot Thanks for your answer.

gdamiand avatar Mar 07 '19 09:03 gdamiand

Conflicts

maxGimeno avatar Jun 17 '19 07:06 maxGimeno

This pull-request has been left untouched for 10 months. I classify in in stalled PRs...

lrineau avatar Oct 02 '19 08:10 lrineau