AmazonSQS icon indicating copy to clipboard operation
AmazonSQS copied to clipboard

Pull Request for multiple messages and batch delete

Open chrissamcat opened this issue 11 years ago • 3 comments

Hi,

Two small enhancements. Extra functions to:

  • allow multiple messages to be received in one webservice call
  • allow batch deletion of messages.

Thanks,

Chris.

chrissamcat avatar Oct 15 '13 23:10 chrissamcat

Hey chrissamcat,

thank you for the pull request.

could you improve the tests? Because currently (wiht your changes) the tests are unstable: https://travis-ci.org/CEikermann/AmazonSQS/builds/12594196

Best regards

CEikermann avatar Oct 18 '13 14:10 CEikermann

Hi,

Yes I have added some more tests and the build is passing now. https://travis-ci.org/CEikermann/AmazonSQS/builds/12723623

Thanks,

Chris.

On Fri, Oct 18, 2013 at 3:00 PM, Christian Eikermann < [email protected]> wrote:

Hey chrissamcat,

could you improve the tests? Because currently (wiht your changes) the tests are unstable: https://travis-ci.org/CEikermann/AmazonSQS/builds/12594196

Best regards

— Reply to this email directly or view it on GitHubhttps://github.com/CEikermann/AmazonSQS/pull/6#issuecomment-26597630 .

chrissamcat avatar Oct 18 '13 15:10 chrissamcat

Hi,

I've wrapped the reponse from DeleteMessageBatch in objects now too, and the test coverage is higher.

Chris,

On Fri, Oct 18, 2013 at 4:44 PM, Chris Gillespie [email protected] wrote:

Hi,

Yes I have added some more tests and the build is passing now. https://travis-ci.org/CEikermann/AmazonSQS/builds/12723623

Thanks,

Chris.

On Fri, Oct 18, 2013 at 3:00 PM, Christian Eikermann < [email protected]> wrote:

Hey chrissamcat,

could you improve the tests? Because currently (wiht your changes) the tests are unstable: https://travis-ci.org/CEikermann/AmazonSQS/builds/12594196

Best regards

— Reply to this email directly or view it on GitHubhttps://github.com/CEikermann/AmazonSQS/pull/6#issuecomment-26597630 .

chrissamcat avatar Oct 19 '13 13:10 chrissamcat