cess

cess copied to clipboard

Why did I get this message?

jmiranda1996

SBP: Improve cleanliness & readability

4

We recommend you to run ``` cargo +nightly fmt --all -- --check ```

NachoPal

SBP: Off-chain worker configuration

2

The use of off-chain worker for fetching the storage price should improved taking into consideration how they work and when they are executed. Some context about things to pay attention...

NachoPal

SBP: Review all your hashers in storage

1

I noticed that you are using `Twox64Concat` by default for all your StorageMap keys. Be aware of the potential issues of choosing the incorrect hasher. From: https://docs.substrate.io/v3/advanced/cryptography/#xxhash > Because xxHash...

NachoPal

SBP: Review all your `unwrap()`

2

Avoid panics at almost any cost and add "proofs" for expect() calls on why they cannot fail. The only reason to panic should be in case a block should not...

NachoPal

SBP: Off-chain worker documentation is outdated

2

https://github.com/CESSProject/sbp-code-docs/blob/main/m1/cess-dscm.md Your off-chain worker is not signing transactions anymore, it is using unsigned transactions instead.

NachoPal

SBP: Benchmarks

2

Improve benchmarks for `file-bank` and replace the fixed weights

NachoPal

SBP: Give indexes to you pallets

4

It is a good practice to give indexes to your runtime pallets. More info here: https://substrate.stackexchange.com/questions/1163/whats-the-logic-behind-polkadots-choice-in-pallet-indexing

NachoPal

SBP: `UnitPrice` issues

1

- [x] `UnitPrice` value should be able to be set from genesis or have a default value. If for some reason OCW http request fails, `UnitPrice` would default to 0....

NachoPal

SBP: Potential overflow issues

2

Review potential overflow situations where operators `+`, `-`, `*` and `/` are used. E.g:https://github.com/CESSProject/cess/blob/main/c-pallets/file-bank/src/lib.rs#L550 If operations are safe it is a good practice to add a comment about why. Use...

NachoPal