perun icon indicating copy to clipboard operation
perun copied to clipboard

feat(core): autoreject applications on expiration

Open mattjoke opened this issue 2 years ago • 1 comments

  • scheduler autorejects all of the group application, if the member is switched to EXPIRED state
  • setStatus also rejects all group applications for Member

mattjoke avatar Sep 05 '23 12:09 mattjoke

I decided to scrap the idea of introducing the logic of the registrar manager to the members manager. Changes:

  • removed the logic used before
  • The two ways to set the status to EXPIRED and reject applications are as follows
    • setStatus method from API, which will do the rejection (NOTE: any other internal calls of setStatus will not trigger the rejection process)
    • scheduler will do the automatic rejection

PROS:

  • same logic and calling the same method will result in the same results
  • no immediate and direct update of the database with new SQLs

CONS:

  • Internal calls of setStatus may need the rejection of the applications

mattjoke avatar Sep 06 '23 10:09 mattjoke