libnetconf2 icon indicating copy to clipboard operation
libnetconf2 copied to clipboard

transition to v2 issues

Open BogdanF01 opened this issue 4 years ago • 7 comments

Hi

I am using devel branch "81916c6 (HEAD -> devel, origin/devel) VERSION bump to version 2.0.8" for libnetconf2 "fd7603e4 (HEAD -> devel, origin/devel) VERSION bump to version 2.0.30" for libyang

I encountered following issues which were not present in v1:

  1. Unexpected child elements in reply Description in the attached files below with the yang models that were used rpc_failure-reply.txt o-ran-troubleshooting.txt rpc_reject-reason.txt o-ran-file-management.txt

  2. Can not read time stamps received in notification body Description in the attached files below with the yang models that were used description.txt o-ran-performance-management.txt

  3. Issue parsing some notifications body Description in the attached files below with the yang models that were used description.txt o-ran-software-management.txt

Could you please help figuring out if I am doing something wrong or something is missing.

Thank you

BogdanF01 avatar Jul 08 '21 12:07 BogdanF01

  1. Should be fixed by https://github.com/CESNET/libnetconf2/issues/317.
  2. That seems correct, the parameter description explains why.
  3. Not exactly sure what the problem may be but if you print op (and also envp) before calling lyd_find_xpath(), it should be obvious what is happening.

michalvasko avatar Jul 09 '21 11:07 michalvasko

Hi,

with update of devel branch to: 5a5d96a2 (HEAD -> devel, origin/devel) VERSION bump to version 2.0.35 for libyang a18739e (HEAD -> devel, origin/devel) VERSION bump to version 2.0.9 for libnetconf2

all my initial problems are solved, now I ran into new ones:

  1. Received an invalid message (Node "next-update-at" not found as a child of "reset" node.). Please see attached file with description. description.txt

Please correct me if im wrong, I was looking in session_client.c , function 'recv_reply()' and I noticed that in v1 NC_MSG_REPLY_ERR_MSGID was returned immediately if expected msg id did not match the one in the queue or the incoming, and now in v2 libyang parsing happens first with call to 'lyd_parse_op()' and this way NC_MSG_REPLY_ERR_MSGID will only be returned if the incoming message is same type as expected one (example: rpc get with id:10 - rpc-reply data for id:9).

  1. Received an invalid message (Unknown XML prefix "xml".). Please see attached file with description. description.txt

Thank you.

BogdanF01 avatar Jul 20 '21 12:07 BogdanF01

You are right, this worked differently or rather did not work in v2. But it seems only a minor change in libyang was needed and it seems to behave the same way now that it did in v1.

michalvasko avatar Jul 21 '21 11:07 michalvasko

Thanks , NC_MSG_REPLY_ERR_MSGID works for me now.

What about 2. Unknown XML prefix "xml". , do you have any feedback on that ?

BogdanF01 avatar Jul 22 '21 07:07 BogdanF01

Sorry, thought it was connected to the first issue. Should work now (with latest libyang devel).

michalvasko avatar Jul 22 '21 09:07 michalvasko

Hi, when is a new release for v2 expected ? thanks.

BogdanF01 avatar Aug 19 '21 07:08 BogdanF01

Should be a few weeks.

michalvasko avatar Aug 24 '21 07:08 michalvasko