mwdb-core icon indicating copy to clipboard operation
mwdb-core copied to clipboard

Fix the padding/margin of the logo on the about page

Open jvoisin opened this issue 2 years ago • 1 comments

Your checklist for this pull request

  • [x] I've read the contributing guideline.
  • [x] I've tested my changes by building and running the project, and testing changed functionality (if applicable)

What is the current behaviour?

With the current logo:

before

With a custom logo:

echap_before

What is the new behaviour?

With the current logo:

image

The margins are a bit wider, but it doesn't really matter, since it makes the page feel less empty anyway.

With a custom logo: echap_after

jvoisin avatar Sep 18 '22 14:09 jvoisin

I'd go for a constant margin to the left of the text div, so the distance between the most-right of the logo and the most-left of the text will always be the same. Personally I favor it over a wider distance

ITAYC0HEN avatar Sep 19 '22 07:09 ITAYC0HEN