cds-videos icon indicating copy to clipboard operation
cds-videos copied to clipboard

fixtures: records fixture is not creating RecordIdentifier

Open hachreak opened this issue 7 years ago • 2 comments

Expected behavior

After cds fixtures records I should be able to create/publish a new video.

Actual behavior

The video publish is failing 2 times and successfully the 3rd.

Information about the Issue

The problem I think is because is not creating the (pidstore) RecordIdentifier and at the moment the user try to publish the video, is creating a RecordIdentified with recid=1 but it still reserved by the video imported by fixture.

Maybe we can "generalize" what we do in CDSRecordDumpLoader and reuse to import fixtures.

Steps to reproduce the behavior

  1. Create from scratch cdslabs_qa
  2. cds fixtures records
  3. Create a new project
  4. Publish the video (fails!)

hachreak avatar Aug 17 '17 08:08 hachreak

@egabancho is this still the case?

ludmilamarian avatar Mar 29 '18 11:03 ludmilamarian

Yes, there is a function responsible for minting the PIDs https://github.com/CERNDocumentServer/cds-videos/blob/cdslabs_qa/cds/modules/fixtures/cli.py#L115, but it does only that, it should also update the sequence for both, recids and report numbers.

egabancho avatar Apr 10 '18 08:04 egabancho