libCEED icon indicating copy to clipboard operation
libCEED copied to clipboard

Change the initialization logic for `useCollograd`.

Open YohannDudouit opened this issue 2 years ago • 10 comments

Avoid using the collocated gradient algorithm when we don't compute any gradient.

YohannDudouit avatar Jul 07 '22 20:07 YohannDudouit

This same change probably also goes in backends/hip-gen, right?

Yes, if you're fine with the change I can spend some time doing it in hip-gen, it should be quick. @nbeams any objection?

YohannDudouit avatar Jul 08 '22 18:07 YohannDudouit

This same change probably also goes in backends/hip-gen, right?

@jeremylt Change propagated to hip-gen.

YohannDudouit avatar Jul 08 '22 18:07 YohannDudouit

Thanks - we can merge once CI does its thing

jeremylt avatar Jul 08 '22 18:07 jeremylt

This change seems to reintroduce the bug we saw in the fluids example, according to the CI

jeremylt avatar Jul 08 '22 22:07 jeremylt

CI got suck, but the PETSc tests still seem to be failing.

jeremylt avatar Jul 13 '22 18:07 jeremylt

The CUDA CI flaked, but the HIP CI is happy now.

jeremylt avatar Jul 14 '22 17:07 jeremylt

The CUDA CI flaked, but the HIP CI is happy now.

Should I run make test on Lassen?

YohannDudouit avatar Jul 14 '22 17:07 YohannDudouit

Does the setup on Lassen do the PETSc tests?

nbeams avatar Jul 14 '22 18:07 nbeams

This has identical changes in CUDA and HIP - CUDA CI is borked but HIP CI is passing so I think we are ok to merge

jeremylt avatar Jul 20 '22 16:07 jeremylt

This has identical changes in CUDA and HIP - CUDA CI is borked but HIP CI is passing so I think we are ok to merge

@jeremylt What would I need to do to reproduce the CI tests locally?

YohannDudouit avatar Jul 21 '22 17:07 YohannDudouit

I merged from main and kicked off a pipeline. Assuming it's good, I think we can squash-merge.

jedbrown avatar Sep 06 '22 16:09 jedbrown