CEmu icon indicating copy to clipboard operation
CEmu copied to clipboard

Fix dynamic MSVC Windows builds

Open programmer2514 opened this issue 2 years ago • 3 comments

programmer2514 avatar Feb 12 '22 23:02 programmer2514

Looks good to me, the dynamic builds were successful: https://github.com/CE-Programming/CEmu/actions/runs/1835120905 Let's just wait for @alberthdev's review I guess? Unless someone else says it's OK.

Anyway, the static builds need to be fixed or removed... In the meantime non-msvc static builds are available on https://jacobly.com/CEmu/master/CEmu64.exe

adriweb avatar Feb 12 '22 23:02 adriweb

Anyway, the static builds need to be fixed or removed...

Haven't quite gotten back to it yet, but we would need another fresh build of static Qt to get things going again. (It's still a WIP, somewhat in hiatus...) Totally fine with disabling the static builds for now (if that's easy to do without completely removing them) until that's back in place again!

alberthdev avatar Feb 13 '22 05:02 alberthdev

I suppose you should clean your PR commits by rebasing?

adriweb avatar May 02 '22 03:05 adriweb

You should probably talk to us on the chan (#cemu-dev on IRC EFNet, or on Discord, the link is in the readme or maybe the toolchain's readme), it'll be simpler to organize the resting of your commits. BTW you should git rebase master your branch instead of merging to keep it up to date, if you want a cleaner commit history.

adriweb avatar Sep 10 '22 19:09 adriweb

Okay, will do. I was just messing around (probably should've made a new branch :/) and was planning to rebase once I actually did anything that worked. I'll hop into the Discord though, sorry for the mess

programmer2514 avatar Sep 10 '22 19:09 programmer2514

I've run the action so you can take a look at what's failing now

adriweb avatar Sep 11 '22 17:09 adriweb

I actually have already fixed the dynamic builds again, and am currently automating building/deploying the latest static Qt5 whenever the corresponding artifacts are missing (see below). I'll merge it into master once I actually get it working (should save you the constant approval spam, and also keep the commit history cleaner).

Yeah, that's an old version. My latest changes can now be found in programmer2514:qt-build-automation until I actually get something working.

programmer2514 avatar Sep 11 '22 18:09 programmer2514

Figured this might as well not stay open with broken commits until I actually get around to fixing it

programmer2514 avatar Sep 20 '22 16:09 programmer2514