CEmu icon indicating copy to clipboard operation
CEmu copied to clipboard

Timers are off

Open jacobly0 opened this issue 6 years ago • 17 comments

I think cpu_restore_next can't be called inside port.c -> sched_process_pending_events. Should I move it out or conditionalize it.

jacobly0 avatar May 25 '18 09:05 jacobly0

Here's the latest timer testing program.

jacobly0 avatar May 25 '18 09:05 jacobly0

Here's the latest timer testing program.

This manages to crash CEmu, actually :P Assertion failed: (0 <= delay && delay <= 2), function gpt_next_event, file ../../core/timers.c, line 64.

adriweb avatar May 25 '18 10:05 adriweb

Move it out :)

mateoconlechuga avatar May 26 '18 15:05 mateoconlechuga

Fixed the cpu_restore_next issue in 9133e0c4c3176cf56dff26db1ef267e93269a255, but now graphing triggers the assert reproducibly.

jacobly0 avatar May 30 '18 04:05 jacobly0

Fixed the graphing assert in 376ed58b272342ea4804bc7c9ef7350d83bef8e2, now back to the original issue.

jacobly0 avatar May 30 '18 08:05 jacobly0

Now enabling a 32K asserts...

jacobly0 avatar May 30 '18 20:05 jacobly0

branch before it's too late ;)

mateoconlechuga avatar May 30 '18 20:05 mateoconlechuga

Fixed this assert with cd7afbd0b85c4be5a7a35cb6009cbc13deb198c8 and fixed all but one case of the offset timers with 93c4cff8f149400f16e7c3719881f3edfe292cc1, now to just fix that.

jacobly0 avatar May 30 '18 20:05 jacobly0

Fixed a bunch of obscure offset issues in 296fb15e18d3c92718a7aa8f534be945b61d3134, so now I think everything works except lines 0-4.

jacobly0 avatar Jun 01 '18 04:06 jacobly0

Nice job!

I've moved to 1.x the two other remaining issues that we originally planned to fix for 1.1, but clearly they'll take some more time to (re)dive into, analyze, and fix. So I guess when this one is closed (or if you think it's good enough as it is now?), it should be good to release v1.1 :)

adriweb avatar Jun 03 '18 08:06 adriweb

Good enough for me :) Let's do a release! :D

mateoconlechuga avatar Jun 03 '18 16:06 mateoconlechuga

Good enough for me :) Let's do a release! :D

I'm just waiting for @jacobly0 to give his green light :P The lang stuff got updated in the meantime.

adriweb avatar Jun 09 '18 08:06 adriweb

Fixed the graphing assert in 376ed58, now back to the original issue.

Just had a freeze when trying to graph something, so it looks like a release will have to wait (assuming it's directly related) for this to be fixed at least :( Repro equation in Y1: fnInt(X,X,0,X) Edit: simpler repro : "XX" (but X² works...)

adriweb avatar Jun 10 '18 15:06 adriweb

Fixed graphing freeze with f3c109c07685da6f4e85733994f8a8de450134f0.

jacobly0 avatar Jun 20 '18 10:06 jacobly0

Yep, can confirm :)

adriweb avatar Jun 20 '18 12:06 adriweb

CLOSE IT :D

mateoconlechuga avatar Jun 20 '18 15:06 mateoconlechuga

#254 was closed a while ago, but this issue is for the few subtle remaining issues, and so won't be closed for some time, and therefore, should not be considered a blocker.

jacobly0 avatar Jun 21 '18 00:06 jacobly0