prime-simplereport icon indicating copy to clipboard operation
prime-simplereport copied to clipboard

syphilis card support pt 3

Open fzhao99 opened this issue 1 year ago • 1 comments

FRONTEND PULL REQUEST

Related Issue

  • The next part of #7436 that refactors the AOE validation process / associated form and other minor cleanup
  • See part 1 and part 2 for more context

Changes Proposed

The PR is pretty big but is mostly just moving around chunks of code / replacing large mocks with composite functions.

  • Move the AOE form validation functions into a central utils folder to be reused by each of the individual AOE forms
  • Simplifying our testing mock setup into some central functions to reduce boilerplate / make the tests easier to read
  • Add some constants / fixes some minor bugs found during testing

Additional Information

Should mostly also be a no-op (the symptom subquestion validation was getting hairy so moved this code out for review first). Syphilis features should be coming in a fourth and final followup

Testing

Verify the AOE / test card validation flows to verify there isn't any regression.

fzhao99 avatar May 08 '24 16:05 fzhao99