prime-reportstream icon indicating copy to clipboard operation
prime-reportstream copied to clipboard

Engagement/hl7data improvements

Open oslynn opened this issue 10 months ago • 6 comments

This PR adds enrichment schema to suppress XTN-12 from PID-13, ORC-14, ORC-23, OBR-17.

Test Steps:

  1. ./gradlew package
  2. ./prime fhirdata --input-file "./single-entry/1/1.fhir" --sender-schema classpath:/metadata/fhir_transforms/senders/SimpleReport/simple-report-sender-transform.yml --enrichment-schemas "classpath:/metadata/fhir_transforms/common/suppress-xtn-12.yml" --receiver-schema classpath:/metadata/hl7_mapping/receivers/STLTs/WI/WI-receiver-transform.yml --output-format HL7 --output-file "./single-entry/1/1_from_fhir.hl7"

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • [x] Tested locally?
  • [x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • [ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
  • [ ] Added tests?

Process

  • [ ] Are there licensing issues with any new dependencies introduced?
  • [ ] Includes a summary of what a code reviewer should test/verify?
  • [ ] Updated the release notes?
  • [ ] Database changes are submitted as a separate PR?
  • [ ] DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

oslynn avatar Feb 04 '25 19:02 oslynn

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

github-actions[bot] avatar Feb 04 '25 19:02 github-actions[bot]

Test Results

1 324 tests  ±0   1 319 :white_check_mark: ±0   7m 39s :stopwatch: -6s   172 suites ±0       5 :zzz: ±0    172 files   ±0       0 :x: ±0 

Results for commit 08d802bb. ± Comparison against base commit a2fd2512.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 04 '25 20:02 github-actions[bot]

Integration Test Results

 60 files   60 suites   37m 41s :stopwatch: 427 tests 417 :white_check_mark: 10 :zzz: 0 :x: 430 runs  420 :white_check_mark: 10 :zzz: 0 :x:

Results for commit 08d802bb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 04 '25 20:02 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
16.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Mar 06 '25 16:03 sonarqubecloud[bot]

:tada: Snyk checks have passed. No issues have been found so far.

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)

scott-aquia avatar May 02 '25 14:05 scott-aquia

Quality Gate Failed Quality Gate failed

Failed conditions
16.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Jun 12 '25 01:06 sonarqubecloud[bot]