prime-reportstream icon indicating copy to clipboard operation
prime-reportstream copied to clipboard

Engagement/jessica/15896 radx mars deidentify

Open JessicaWNava opened this issue 1 year ago • 4 comments

This PR updated the RADX Mars deidentification schema to meet their new spec.

Test Steps:

  1. Make sure the integration tests pass.
  2. Compare the changes to those requested here: https://www.nibib.nih.gov/covid-19/radx-tech-program/mars/hl7-message-de-identification-for-sending-to-hhs-protect

Changes

  • Updated the deidentification transform
  • Updated the corresponding integration test.

Checklist

Testing

  • [x] Tested locally?
  • [ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • [ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
  • [ ] Added tests?

Process

  • [ ] Are there licensing issues with any new dependencies introduced?
  • [ ] Includes a summary of what a code reviewer should test/verify?
  • [ ] Updated the release notes?
  • [ ] Database changes are submitted as a separate PR?
  • [ ] DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

JessicaWNava avatar Oct 10 '24 13:10 JessicaWNava

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

github-actions[bot] avatar Oct 10 '24 13:10 github-actions[bot]

Test Results

1 245 tests  ±0   1 241 :white_check_mark: ±0   7m 43s :stopwatch: -10s   162 suites ±0       4 :zzz: ±0    162 files   ±0       0 :x: ±0 

Results for commit afbe3c57. ± Comparison against base commit 1ff8ce40.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 10 '24 13:10 github-actions[bot]

Integration Test Results

 53 files   53 suites   28m 1s :stopwatch: 411 tests 402 :white_check_mark: 9 :zzz: 0 :x: 414 runs  405 :white_check_mark: 9 :zzz: 0 :x:

Results for commit afbe3c57.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 10 '24 14:10 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 17 '24 13:10 sonarqubecloud[bot]