Enhance lineage assertions in routing tests
User Story
As a developer I want comprehensive tests so that I can catch any issues before they go to production.
Description/Use Case
The tests in routing functions DestinationFilter and ReceiverFilter don't check several pieces of metadata associated on output Report objects. We should add these checks where it makes sense.
Risks/Impacts/Considerations
Dev Notes
These live in FhirDestinationFilterIntegrationTests.kt and FhirReceiverFilterIntegrationTest.kt
This ticket got closed as a duplicate but contains helpful context for this ticket and all the AC there should be met here as well: https://github.com/CDCgov/prime-reportstream/issues/14349
Acceptance Criteria
FhirDestinationFilterIntegrationTests- [ ]
Reportobjects retrieved; relevant properties checked when report does not get routed anywhere - [ ]
Reportobject retrieved; contents and properties checked when report is routed
- [ ]
FhirReceiverFilterIntegrationTests- [ ]
Reportobject retrieved; contents and properties checked when report does not get routed anywhere
- [ ]
- Verify lineages are adequately checked in
fetchChildReports- [ ] Double-check the lineage assertions for ItemLineage and ReportLineage
- [ ] Ensure we are calling
fetchChildReportseven if we expect no child reports - [ ] Revisit usage in other tests (Convert and Translate) and create tickets as needed
Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @brick-green @david-navapbc @jack-h-wang @jalbinson @JFisk42 @mkalish @thetaurean
I have expanded the scope of this ticket and bumped the points from 2 to 3.
Several teammates already commented it's probably a 3 even before this change.