prime-reportstream icon indicating copy to clipboard operation
prime-reportstream copied to clipboard

Enhance lineage assertions in routing tests

Open thetaurean opened this issue 1 year ago • 1 comments

User Story

As a developer I want comprehensive tests so that I can catch any issues before they go to production.

Description/Use Case

The tests in routing functions DestinationFilter and ReceiverFilter don't check several pieces of metadata associated on output Report objects. We should add these checks where it makes sense.

Risks/Impacts/Considerations

Dev Notes

These live in FhirDestinationFilterIntegrationTests.kt and FhirReceiverFilterIntegrationTest.kt

This ticket got closed as a duplicate but contains helpful context for this ticket and all the AC there should be met here as well: https://github.com/CDCgov/prime-reportstream/issues/14349

Acceptance Criteria

  • FhirDestinationFilterIntegrationTests
    • [ ] Report objects retrieved; relevant properties checked when report does not get routed anywhere
    • [ ] Report object retrieved; contents and properties checked when report is routed
  • FhirReceiverFilterIntegrationTests
    • [ ] Report object retrieved; contents and properties checked when report does not get routed anywhere
  • Verify lineages are adequately checked in fetchChildReports
    • [ ] Double-check the lineage assertions for ItemLineage and ReportLineage
    • [ ] Ensure we are calling fetchChildReports even if we expect no child reports
    • [ ] Revisit usage in other tests (Convert and Translate) and create tickets as needed

thetaurean avatar Aug 12 '24 16:08 thetaurean

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @brick-green @david-navapbc @jack-h-wang @jalbinson @JFisk42 @mkalish @thetaurean

Andrey-Glazkv avatar Aug 12 '24 16:08 Andrey-Glazkv

I have expanded the scope of this ticket and bumped the points from 2 to 3.

Several teammates already commented it's probably a 3 even before this change.

thetaurean avatar Aug 23 '24 20:08 thetaurean