14413: fetch all conditions for mapping at once
This PR ...
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Test Steps:
- Include steps to test these changes
Changes
- Include a comprehensive list of changes in this PR
- (For web UI changes) Include screenshots/video of changes
Checklist
Testing
- [ ] Tested locally?
- [ ] Ran
./prime testor./gradlew testSmokeagainst local Docker ReportStream container? - [ ] (For Changes to /frontend-react/...) Ran
npm run lint:write? - [ ] Added tests?
Process
- [ ] Are there licensing issues with any new dependencies introduced?
- [ ] Includes a summary of what a code reviewer should test/verify?
- [ ] Updated the release notes?
- [ ] Database changes are submitted as a separate PR?
- [ ] DevOps team has been notified if PR requires ops support?
Linked Issues
- Fixes #issue
To Be Done
Create GitHub issues to track the work remaining, if any
- #issue
Specific Security-related subjects a reviewer should pay specific attention to
- Does this PR introduce new endpoints?
- new endpoint A
- new endpoint B
- Does this PR include changes in authentication and/or authorization of existing endpoints?
- Does this change introduce new dependencies that need vetting?
- Does this change require changes to our infrastructure?
- Does logging contain sensitive data?
- Does this PR include or remove any sensitive information itself?
If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:
- What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
- Spoofing (faking authenticity)
- Threat T, which could be achieved by A, is mitigated by M
- Tampering (influence or sabotage the integrity of information, data, or system)
- Repudiation (the ability to dispute the origin or originator of an action)
- Information disclosure (data made available to entities who should not have it)
- Denial of service (make a resource unavailable)
- Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
- Spoofing (faking authenticity)
- Have you ensured logging does not contain sensitive data?
- Have you received any additional approvals needed for this change?
Dependency Review
✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
| Package | Version | Score | Details |
|---|
Scanned Manifest Files
Test Results
1 198 tests +1 1 194 :white_check_mark: +1 6m 39s :stopwatch: +12s 152 suites ±0 4 :zzz: ±0 152 files ±0 0 :x: ±0
Results for commit 814a7569. ± Comparison against base commit a3947913.
:recycle: This comment has been updated with latest results.
Integration Test Results
62 files 62 suites 33m 5s :stopwatch: 395 tests 385 :white_check_mark: 10 :zzz: 0 :x: 398 runs 388 :white_check_mark: 10 :zzz: 0 :x:
Results for commit 814a7569.
:recycle: This comment has been updated with latest results.
Figures are in milliseconds and I went with the last tests I ran. But for all scenarios I ran multiple tests and the results all roughly persisted.
| Master Branch | Kalish Branch | |
|---|---|---|
| FHIR Batch 600 | 13256 | 3836 |
| FHIR Single | 1846 | 22 |
| HL7 Batch 600 | 13346 | 2772 |
| HL7 Single | 293 | 89 |
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code