prime-reportstream icon indicating copy to clipboard operation
prime-reportstream copied to clipboard

backend dotenv

Open jpandersen87 opened this issue 1 year ago • 4 comments

This PR is a quality of life improvement to how environment variables are handled for local gradle tasks (these variables are NOT used in the prime-router application being built when it is ran).

  • All environment variables from docker yaml and gradle build moved to .env file
    • host-specific overrides that are used in gradle build have a host (capitalization depending on existing pattern) prefix
  • build fun loadDotEnv added
    • creates map variable of the following in priority least to greatest:
      • .env
      • .env.local
      • host environment
      • project properties
    • applies specific overrides (docker hostname to localhost) to particular variables if one wasn't supplied manually via host environment or project properties
  • build vault fun updated to create new map (applying vault variables on top) from provided map
  • env var accesses replaced with dotEnv
  • Prime-router .gitignore initialized using the root .gitignore
    • Entry ignoring .env.local / .env.*.local files added to .gitignore
  • prime-router specific .gitignore entries removed from root .gitignore
  • docker compose usages across github actions, un-deprecated documentation, scripts, etc. updated to use dotenv file

jpandersen87 avatar May 14 '24 00:05 jpandersen87

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

github-actions[bot] avatar May 14 '24 00:05 github-actions[bot]

Test Results

0 tests   - 1 172   0 :white_check_mark:  - 1 168   0s :stopwatch: - 6m 57s 0 suites  -   147   0 :zzz:  -     4  0 files    -   147   0 :x: ±    0 

Results for commit 281cc936. ± Comparison against base commit eca9466a.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 14 '24 00:05 github-actions[bot]

Integration Test Results

0 files   -  62  0 suites   - 62   0s :stopwatch: - 33m 29s 0 tests  - 394  0 :white_check_mark:  - 384  0 :zzz:  - 10  0 :x: ±0  0 runs   - 397  0 :white_check_mark:  - 387  0 :zzz:  - 10  0 :x: ±0 

Results for commit 281cc936. ± Comparison against base commit eca9466a.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 14 '24 00:05 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 15 '24 20:05 sonarqubecloud[bot]