prime-reportstream icon indicating copy to clipboard operation
prime-reportstream copied to clipboard

14249 add fhir inventory java class

Open jack-h-wang opened this issue 1 year ago • 4 comments

This PR adds a HL7 message class that covers RS relevant data elements from the FHIR mapping inventory and updates catchall mappings to cover the additions.

Test Steps:

  1. Verify the class updates match the FHIR mapping inventory.

Changes

  • Add HL7 message class based on FHIR mapping inventory (replaces RADx MARS message class)
  • Change HL7Reader to use the new message class.
  • Update mappings and tests for NTE, OBR, OBX, and ORC segments.

Checklist

Testing

  • [x] Tested locally?
  • [x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • [x] Added tests?

Linked Issues

  • #14249

To Be Done

  • PRT mappings
  • OBX-33 mappings
  • #14343

jack-h-wang avatar May 09 '24 22:05 jack-h-wang

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

github-actions[bot] avatar May 09 '24 22:05 github-actions[bot]

Test Results

1 200 tests  ±0   1 196 :white_check_mark: ±0   6m 43s :stopwatch: +7s   152 suites ±0       4 :zzz: ±0    152 files   ±0       0 :x: ±0 

Results for commit 805db0b8. ± Comparison against base commit 6e1475e5.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 22:05 github-actions[bot]

Integration Test Results

 62 files   62 suites   34m 17s :stopwatch: 395 tests 385 :white_check_mark: 10 :zzz: 0 :x: 398 runs  388 :white_check_mark: 10 :zzz: 0 :x:

Results for commit 805db0b8.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 22:05 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
19.0% Coverage on New Code (required ≥ 80%)
46.4% Duplication on New Code (required ≤ 3%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar May 31 '24 15:05 sonarqubecloud[bot]