prime-reportstream icon indicating copy to clipboard operation
prime-reportstream copied to clipboard

Platform/13506/int tests for fhir router

Open david-navapbc opened this issue 1 year ago • 6 comments

This PR ...

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. Include steps to test these changes

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • [ ] Tested locally?
  • [ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • [ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
  • [ ] Added tests?

Process

  • [ ] Are there licensing issues with any new dependencies introduced?
  • [ ] Includes a summary of what a code reviewer should test/verify?
  • [ ] Updated the release notes?
  • [ ] Database changes are submitted as a separate PR?
  • [ ] DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

david-navapbc avatar Apr 30 '24 16:04 david-navapbc

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

github-actions[bot] avatar Apr 30 '24 16:04 github-actions[bot]

Test Results

1 213 tests  +9   1 209 :white_check_mark: +9   6m 32s :stopwatch: +20s   153 suites +1       4 :zzz: ±0    153 files   +1       0 :x: ±0 

Results for commit bab21afb. ± Comparison against base commit 3b999fe6.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 30 '24 16:04 github-actions[bot]

Integration Test Results

 62 files   62 suites   28m 4s :stopwatch: 400 tests 390 :white_check_mark: 10 :zzz: 0 :x: 403 runs  393 :white_check_mark: 10 :zzz: 0 :x:

Results for commit bab21afb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 30 '24 16:04 github-actions[bot]

@david-navapbc Looks like there are a bunch of linting errors, might want to confirm that the pre-commit hooks are set up to run

mkalish avatar May 20 '24 22:05 mkalish

Also @david-navapbc still looks like you have a linting error, I would double check that you have the pre-commit hooks set up

mkalish avatar May 23 '24 22:05 mkalish