phdi icon indicating copy to clipboard operation
phdi copied to clipboard

Add `tsc` to ecr-viewer linting process

Open BobanL opened this issue 1 year ago • 0 comments

What needs to be done

  • Add tsc --noEmit to our linting process

Why it needs to be done

  • Currently there are 7 typescript errors in our files

image

Acceptance Criteria

List out all expected functionality/requirements

  • tsc --noEmit returns back 0 errors
  • tsc --noEmit is part of the "lint" script.

Technical Notes

Owned by eng team - write out any important technical considerations such as: architecture plan/notes, data dependencies, testing plan, etc. Also link any tickets that are dependent on or related to this task

  • https://www.typescriptlang.org/tsconfig/#noEmit

BobanL avatar Jul 25 '24 15:07 BobanL