m2 icon indicating copy to clipboard operation
m2 copied to clipboard

Use Pylint instead of pep8 in travis ci

Open chemistry-sourabh opened this issue 8 years ago • 6 comments

pep8 just checks style conventions whereas pylint also checks for compile issues which is useful before running actual tests.

chemistry-sourabh avatar Feb 25 '17 18:02 chemistry-sourabh

just read about pylint. Seems like a good idea to have it.

naved001 avatar Feb 27 '17 18:02 naved001

let other @CCI-MOC/bmi-breakers also respond

chemistry-sourabh avatar Feb 27 '17 19:02 chemistry-sourabh

+1

sirushtim avatar Mar 02 '17 15:03 sirushtim

+1000 - I just looked at the documentation. Seems it has lot of stuff like code analysis(which can help in refactoring etc).

ravisantoshgudimetla avatar Apr 05 '17 23:04 ravisantoshgudimetla

It would be a good idea to enable one feature of pylint at a time, like how we are doing it in HIL.

https://github.com/CCI-MOC/hil/blob/master/ci/pylint_tests.sh#L8-L17

I think it took 4-5 PRs to enable those checks in pylint.

naved001 avatar Sep 07 '17 12:09 naved001

Looks like we'll be rewriting most of the code, so it would be a good idea to enable pylint from the beginning.

naved001 avatar Nov 22 '17 15:11 naved001